Skip to content

Upgrade NAN to ^2.15.0 - #57

Closed
heathcliff-hu wants to merge 1 commit into
msgpack:masterfrom
heathcliff-hu:feature/nan
Closed

heathcliff-hu wants to merge 1 commit into
msgpack:masterfrom
heathcliff-hu:feature/nan

Conversation

@heathcliff-hu

@heathcliff-hu heathcliff-hu commented Sep 8, 2021

Copy link
Copy Markdown

fix: #55
support node 16

newbee1905 added a commit to newbee1905/msgpack-node that referenced this pull request Jan 24, 2022
@enochgroot

Copy link
Copy Markdown
Collaborator

Superseded by 2.0.0 (#25687, e04c9b5). nan is already ^2.23.1, and Node 16 is outside engines.node: ">=18".

@enochgroot

Copy link
Copy Markdown
Collaborator

Re-evaluated on master e04c9b55 (2.0.0).

package.json already has "nan": "^2.23.1"; the install on this tree resolved nan 2.28.0. Closing this PR as superseded.

@enochgroot enochgroot closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

electron-rebuild and g++ issue

2 participants